Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add an hoursBack query param to the raw metrics endpoint #1373

Merged
merged 6 commits into from
Feb 17, 2022

Conversation

olav
Copy link
Contributor

@olav olav commented Feb 16, 2022

Needed by the the new feature toggle metrics page.

@vercel
Copy link

vercel bot commented Feb 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/DEjijaaDRHv2ESBySoL4HLnKfpHu
✅ Preview: https://unleash-docs-git-metric-hours-unleash-team.vercel.app

@github-actions
Copy link

github-actions bot commented Feb 16, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 91.4% 4742/5188
🟢 Branches 80.35% 728/906
🟢 Functions 86.64% 1109/1280
🟢 Lines 91.33% 4644/5085

Test suite run success

790 tests passing in 116 suites.

Report generated by 🧪jest coverage report action from 4f29421

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We might want a test for this. WDYT @ivarconr @chriswk ?

src/lib/routes/admin-api/client-metrics.ts Outdated Show resolved Hide resolved
@sighphyre
Copy link
Member

Looks good, aside from some minor style things!

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good with tests! Nice :)

src/test/e2e/api/admin/client-metrics.e2e.test.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants