New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add how to schedule feature releases guide #1440
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/8CPAcPG77vKNY8NmxqXBmEqaxgDE |
Coverage report
Test suite run success821 tests passing in 118 suites. Report generated by 🧪jest coverage report action from 0a34661 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Great work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
## Prerequisites | ||
|
||
This guide assumes that you've got the following: | ||
- some basic experience with Unleash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete and utter nitpick but sometimes we use capitalised first letters in lists in this page and sometimes we don't, might be cleaner if we stick to one style unless there's overriding reasons to mix styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree that it would be cleaner! This is already merged in now, but I'll keep that in mind going forward. It does depend a bit on the context (I think), though. E.g.:
I want to ...
- do a
- do b
Unleash has a number of security mechanisms built in:
- When blah blah ...
- The thingamabob ...
But maybe standardizing on always capitalizing would work well, now that I think about it 🤔 Great input either way!
This adds a how-to guide for scheduling feature releases. It contains steps both for using advanced constraint operators and for doing it with custom activation strategies.
To avoid repeating the same information that's mentioned in other how-to guides, it makes liberal use of links, especially in explaining how to implement custom activation strategies