Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add how to schedule feature releases guide #1440

Merged
merged 5 commits into from Mar 18, 2022

Conversation

thomasheartman
Copy link
Contributor

This adds a how-to guide for scheduling feature releases. It contains steps both for using advanced constraint operators and for doing it with custom activation strategies.

To avoid repeating the same information that's mentioned in other how-to guides, it makes liberal use of links, especially in explaining how to implement custom activation strategies

@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/8CPAcPG77vKNY8NmxqXBmEqaxgDE
✅ Preview: https://unleash-docs-git-docs-how-to-time-feature-releases-unleash-team.vercel.app

@github-actions
Copy link

github-actions bot commented Mar 15, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 91.28% 4902/5370
🟡 Branches 79.89% 751/940
🟢 Functions 86.5% 1147/1326
🟢 Lines 91.19% 4794/5257

Test suite run success

821 tests passing in 118 suites.

Report generated by 🧪jest coverage report action from 0a34661

@thomasheartman
Copy link
Contributor Author

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Great work :)

@thomasheartman thomasheartman merged commit 59609a8 into main Mar 18, 2022
@thomasheartman thomasheartman deleted the docs/how-to-time-feature-releases branch March 18, 2022 08:30
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

## Prerequisites

This guide assumes that you've got the following:
- some basic experience with Unleash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete and utter nitpick but sometimes we use capitalised first letters in lists in this page and sometimes we don't, might be cleaner if we stick to one style unless there's overriding reasons to mix styles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree that it would be cleaner! This is already merged in now, but I'll keep that in mind going forward. It does depend a bit on the context (I think), though. E.g.:

I want to ...

  • do a
  • do b

Unleash has a number of security mechanisms built in:

  • When blah blah ...
  • The thingamabob ...

But maybe standardizing on always capitalizing would work well, now that I think about it 🤔 Great input either way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants