Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add segment limits #1469

Merged
merged 2 commits into from
Apr 1, 2022
Merged

feat: add segment limits #1469

merged 2 commits into from
Apr 1, 2022

Conversation

olav
Copy link
Contributor

@olav olav commented Mar 28, 2022

@vercel
Copy link

vercel bot commented Mar 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/EzDHZfWUyF7upi7UVSQzZwGwRN2b
✅ Preview: https://unleash-docs-git-segment-api-limits-unleash-team.vercel.app

@github-actions
Copy link

github-actions bot commented Mar 28, 2022

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 91.14% 5043/5533
🟡 Branches 79.67% 776/974
🟢 Functions 86.11% 1190/1382
🟢 Lines 91.08% 4929/5412
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / segments.ts
100% 100% 100% 100%

Test suite run success

834 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from 221628a

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few thoughts here but they're just double checking things, feel free to ignore them if you know better

src/lib/experimental.ts Outdated Show resolved Hide resolved
src/lib/services/segment-service.ts Outdated Show resolved Hide resolved
@olav olav merged commit 1da3878 into main Apr 1, 2022
@olav olav deleted the segment-api-limits branch April 1, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants