Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow instance ID to be empty for metrics #1471

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix: allow instance ID to be empty for metrics #1471

merged 1 commit into from
Apr 1, 2022

Conversation

olav
Copy link
Contributor

@olav olav commented Mar 31, 2022

No description provided.

@olav olav requested a review from ivarconr March 31, 2022 09:10
@vercel
Copy link

vercel bot commented Mar 31, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/FRWRH1NPfERhZ3bg6oNP5ESw6i3F
✅ Preview: https://unleash-docs-git-metrics-instance-unleash-team.vercel.app

@olav olav removed the request for review from ivarconr March 31, 2022 09:11
@github-actions
Copy link

github-actions bot commented Mar 31, 2022 •
edited

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 91.1% 5024/5515
🟡 Branches 79.77% 773/969
🟢 Functions 85.92% 1184/1378
🟢 Lines 91.03% 4910/5394

Test suite run success

831 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from 88e120d

@olav olav changed the title fix: allow instance ID to be emtpy for metrics fix: allow instance ID to be empty for metrics Mar 31, 2022
sighphyre
sighphyre approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olav olav merged commit cf06b56 into main Apr 1, 2022
@olav olav deleted the metrics-instance branch April 1, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olav @sighphyre