Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add context value descriptions #1496

Merged
merged 3 commits into from
Apr 19, 2022
Merged

feat: add context value descriptions #1496

merged 3 commits into from
Apr 19, 2022

Conversation

olav
Copy link
Contributor

@olav olav commented Apr 11, 2022

No description provided.

@vercel
Copy link

vercel bot commented Apr 11, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/unleash-team/unleash-docs/EUsYYjbcvzuLL2qG2FSUBGDD1qWq
✅ Preview: https://unleash-docs-git-context-meta-unleash-team.vercel.app

@github-actions
Copy link

github-actions bot commented Apr 11, 2022 •
edited

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 91.14% 5104/5600
🟡 Branches 79.68% 796/999
🟢 Functions 86.27% 1206/1398
🟢 Lines 91.07% 4988/5477

Test suite run success

845 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from 506b074

@olav olav marked this pull request as ready for review April 13, 2022 06:08
chriswk
chriswk reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly used for validation on the frontend?

@chriswk
Copy link
Contributor

chriswk commented Apr 13, 2022

As long as we're not breaking our client SDKs, this seems good

chriswk
chriswk approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olav
Copy link
Contributor Author

olav commented Apr 13, 2022

This is mostly used for validation on the frontend?

Yep! Just an Admin API thing.

FredrikOseberg
FredrikOseberg requested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close to done I think.

src/migrations/20220411103724-add-legal-value-description.js Outdated Show resolved Hide resolved
FredrikOseberg
FredrikOseberg approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel
Copy link

vercel bot commented Apr 19, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-docs ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 6:28AM (UTC)

@olav olav merged commit e38f7cf into main Apr 19, 2022
@olav olav deleted the context-meta branch April 19, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk chriswk approved these changes

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olav @chriswk @FredrikOseberg