Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disallow additionalProperties in response schemas #1543

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

olav
Copy link
Contributor

@olav olav commented Apr 28, 2022

Avoids a tricky index signature in the generated Response types.

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-docs ✅ Ready (Inspect) Visit Preview Apr 28, 2022 at 10:57AM (UTC)

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 91.2% 5171/5670
🟡 Branches 79.31% 805/1015
🟢 Functions 86.18% 1216/1411
🟢 Lines 91.12% 5050/5542

Test suite run success

860 tests passing in 124 suites.

Report generated by 🧪jest coverage report action from 4e036b6

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGreatTM 🚂

@olav olav merged commit c028655 into main Apr 29, 2022
@olav olav deleted the add-props branch April 29, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants