feat: Allow extra CSP domains #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
chriswk
force-pushed
the
feat/allowExtraCspDomains
branch
from
fe82272
to
5ab1c6b
Compare
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
chriswk
force-pushed
the
feat/allowExtraCspDomains
branch
from
ede3d85
to
93e5729
Compare
chriswk
force-pushed
the
feat/allowExtraCspDomains
branch
from
93e5729
to
a5f777c
Compare
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success887 tests passing in 125 suites. Report generated by 🧪jest coverage report action from e683d93 |
olav
suggested changes
May 30, 2022
src/lib/middleware/secure-headers.ts
Outdated
| "'self'", | ||
| 'cdn.getunleash.io', | ||
| 'gravatar.com', | ||
| ...config.additionalCspAllowedDomains?.defaultSrc, |
There was a problem hiding this comment.
Will these spreads crash if additionalCspAllowedDomains is undefined?
There was a problem hiding this comment.
No, because if additionalCspAllowedDomains is undefined parseCspEnvironmentVariables() will trigger and provide defaults.
There was a problem hiding this comment.
Oh right! Maybe additionalCspAllowedDomains can be required in IUnleashConfig then, to remove the ?s.
olav
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up our hosted instance we would really like to be allowed to add another domain to our allowed source domains, so that we can add plausible integration.
Co-authored-by: Fredrik Oseberg fredrik.no@gmail.com