Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add svelte and vue front-end SDKs #1760

Merged
merged 9 commits into from Jun 29, 2022
Merged

docs: add svelte and vue front-end SDKs #1760

merged 9 commits into from Jun 29, 2022

Conversation

nunogois
Copy link
Member

Also re-ordered them and made them more consistent on the bootstrapping section.

@vercel
Copy link

vercel bot commented Jun 28, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-docs ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 2:20PM (UTC)

@github-actions
Copy link

github-actions bot commented Jun 28, 2022 •
edited

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 91.89% 5623/6119
🟢 Branches
80.85% (+1.3% 🔼)
 874/1081
🟢 Functions 86.47% 1253/1449
🟢 Lines 91.82% 5491/5980
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢 lib/util/env.ts 100% 100% 100% 100%
🟢
... / validateJsonString.ts
 100% 100% 100% 100%
🟢 lib/util/semver.ts 92.86% 100% 100% 91.67%
🟢
... / api-token-schema.ts
 100% 100% 100% 100%
🟢
... / api-tokens-schema.ts
 100% 100% 100% 100%
🟢
... / context-field-schema.ts
 100% 100% 100% 100%
🟢
... / legal-value-schema.ts
 100% 100% 100% 100%
🟢
... / context-fields-schema.ts
 100% 100% 100% 100%
🟢
... / create-api-token-schema.ts
 100% 100% 100% 100%
🟢
... / create-user-schema.ts
 100% 100% 100% 100%
🟢
... / create-feature-strategy-schema.ts
 100% 100% 100% 100%
🟢
... / environment-schema.ts
 100% 100% 100% 100%
🟢
... / environments-schema.ts
 100% 100% 100% 100%
🟢
... / feature-environment-schema.ts
 100% 100% 100% 100%
🟢
... / feature-type-schema.ts
 100% 100% 100% 100%
🟢
... / feature-types-schema.ts
 100% 100% 100% 100%
🟢
... / feature-variants-schema.ts
 100% 100% 100% 100%
🟢
... / feedback-schema.ts
 100% 100% 100% 100%
🟢
... / health-check-schema.ts
 100% 100% 100% 100%
🟢
... / health-overview-schema.ts
 100% 100% 100% 100%
🟢
... / health-report-schema.ts
 100% 100% 100% 100%
🟢
... / login-schema.ts
 100% 100% 100% 100%
🟢
... / id-schema.ts
 100% 100% 100% 100%
🟢
... / map-values.ts
 100% 100% 100% 100%
🟢
... / name-schema.ts
 100% 100% 100% 100%
🟢
... / me-schema.ts
 100% 100% 100% 100%
🟢
... / user-schema.ts
 100% 100% 100% 100%
🟢
... / permission-schema.ts
 100% 100% 100% 100%
🟢
... / omit-keys.ts
 100% 100% 100% 100%
🟢
... / password-schema.ts
 100% 100% 100% 100%
🟢
... / patch-schema.ts
 100% 100% 100% 100%
🟢
... / patches-schema.ts
 100% 100% 100% 100%
🟢
... / project-environment-schema.ts
 100% 100% 100% 100%
🟢
... / project-schema.ts
 100% 100% 100% 100%
🟢
... / projects-schema.ts
 100% 100% 100% 100%
🟢
... / role-schema.ts
 100% 100% 100% 100%
🟢
... / sort-order-schema.ts
 100% 100% 100% 100%
🟢
... / splash-schema.ts
 100% 100% 100% 100%
🟢
... / tags-schema.ts
 100% 100% 100% 100%
🟢
... / tag-type-schema.ts
 100% 100% 100% 100%
🟢
... / tag-types-schema.ts
 100% 100% 100% 100%
🟢
... / ui-config-schema.ts
 100% 100% 100% 100%
🟢
... / version-schema.ts
 100% 100% 100% 100%
🟢
... / update-feature-schema.ts
 100% 100% 100% 100%
🟢
... / update-feature-strategy-schema.ts
 100% 100% 100% 100%
🟢
... / update-api-token-schema.ts
 100% 100% 100% 100%
🟢
... / update-tag-type-schema.ts
 100% 100% 100% 100%
🟢
... / upsert-context-field-schema.ts
 100% 100% 100% 100%
🟢
... / update-user-schema.ts
 100% 100% 100% 100%
🟢
... / users-schema.ts
 100% 100% 100% 100%
🟢
... / users-search-schema.ts
 100% 100% 100% 100%
🟢
... / validate-tag-type-schema.ts
 100% 100% 100% 100%
🟢
... / variants-schema.ts
 100% 100% 100% 100%
🟢
... / feature-environment-metrics-schema.ts
 100% 100% 100% 100%
🟢
... / feature-usage-schema.ts
 100% 100% 100% 100%
🟢
... / feature-metrics-schema.ts
 100% 100% 100% 100%
🟢
... / addon-schema.ts
 100% 100% 100% 100%
🟢
... / addons-schema.ts
 100% 100% 100% 100%
🟢
... / addon-type-schema.ts
 100% 100% 100% 100%
🟢
... / addon-parameter-schema.ts
 100% 100% 100% 100%
🟢
... / application-schema.ts
 100% 100% 100% 100%
🟢
... / applications-schema.ts
 100% 100% 100% 100%
🟢
... / tag-with-version-schema.ts
 100% 100% 100% 100%
🟢
... / token-user-schema.ts
 100% 100% 100% 100%
🟢
... / change-password-schema.ts
 100% 100% 100% 100%
🟢
... / validate-password-schema.ts
 100% 100% 100% 100%
🟢
... / reset-password-schema.ts
 100% 100% 100% 100%
🟢
... / feature-strategy-segment-schema.ts
 100% 100% 100% 100%
🟢
... / segment-schema.ts
 100% 100% 100% 100%
🟢
... / state-schema.ts
 100% 100% 100% 100%
🟢
... / feature-tag-schema.ts
 100% 100% 100% 100%
🟢
... / export-parameters-schema.ts
 100% 100% 100% 100%
🟢
... / email-schema.ts
 100% 100% 100% 100%
🟢
... / strategies-schema.ts
 100% 100% 100% 100%
🟢
... / upsert-strategy-schema.ts
 100% 100% 100% 100%
🟢
... / client-application-schema.ts
 100% 100% 100% 100%
🟢
... / serialize-dates.ts
 100% 100% 100% 100%
🟢
... / anonymise.ts
 100% 100% 100% 100%
🟢
... / bootstrap.ts
 100% 100% 100% 100%
🟢
... / api-token.ts
 92.86% 60% 100% 92.68%
🟢
... / user-feedback.ts
 100% 71.43% 100% 100%
🟢
... / user-splash.ts
 100% 100% 100% 100%
🟢
... / environments.ts
 100% 100% 100% 100%
🟢
... / isDefined.ts
 100% 100% 100% 100%
🟢
... / validate.ts
 100% 66.67% 100% 100%
🟢
... / client-spec-service.ts
 100% 100% 100% 100%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / feature-toggle-client-store.ts
98.53% (-1.47% 🔻)
81.48% (+4.56% 🔼)
 100%
98.53% (-1.47% 🔻)
🟢
... / create-config.ts
 96.69%
91.11% (+6.04% 🔼)
90% (-10% 🔻)
 96.61%
🟡
... / access-service.ts
 79.71% 93.1% 82% 78.63%
🟢 lib/routes/util.ts
84.85% (-3.03% 🔻)
73.68% (-5.26% 🔻)
 100%
84.38% (-3.13% 🔻)
🟢
... / constraint-types.ts
93.33% (-3.44% 🔻)
83.33% (-16.67% 🔻)
 85.71%
91.67% (-4.17% 🔻)
🟢
... / controller.ts
96.88% (-3.13% 🔻)
 100%
93.33% (-6.67% 🔻)
96.77% (-3.23% 🔻)
🟢
... / user-admin.ts
90.8% (+3.9% 🔼)
66.67% (-13.33% 🔻)
76.92% (-6.41% 🔻)
91.86% (+4.96% 🔼)
🟢
... / features.ts
 91.89% 100% 89.47% 91.89%
🟢
... / user-service.ts
88.97% (-1.18% 🔻)
69.39% (-1.34% 🔻)
 86.36%
89.55% (-1.22% 🔻)
🔴
... / password-undefined.ts
14.29% (-85.71% 🔻)
 100%
0% (-100% 🔻)
14.29% (-85.71% 🔻)
🟡
... / user-splash-service.ts
69.23% (-2.2% 🔻)
 0% 80%
69.23% (-2.2% 🔻)

Test suite run success

971 tests passing in 157 suites.

Report generated by 🧪jest coverage report action from c6a142c

@nunogois nunogois marked this pull request as ready for review June 28, 2022 11:22
thomasheartman
thomasheartman approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks for adding them 😄 I only have one small request as called out in the comment, but I trust you to fix that and then merge when you feel like it 🙌🏼

website/docs/sdks/index.md Outdated Show resolved Hide resolved
thomasheartman
thomasheartman requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the folding admonition, but I think you might have fixed that locally already? I've marked it as a requested change regardless.

Were you also going to re-order the community SDKs by language? ☺️

website/docs/sdks/index.md Outdated Show resolved Hide resolved
thomasheartman
thomasheartman requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! One more change suggestion and it's good to go.

I also didn't realize we had that list of proxy sdks stored in that many places. We should definitely do something about that sometime 😅

website/docs/sdks/proxy-svelte.md Outdated Show resolved Hide resolved
@nunogois @thomasheartman
Update website/docs/sdks/proxy-svelte.md
f1ead0f 
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
thomasheartman
thomasheartman approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Let's get it in 🚂

@nunogois nunogois merged commit 5ba5edc into main Jun 29, 2022
@nunogois nunogois deleted the docs/add-svelte-vue-sdks branch June 29, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasheartman thomasheartman thomasheartman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nunogois @thomasheartman