Added missing archivedAt to featureSchema #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added archived_at to db
# Conflicts: # src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success992 tests passing in 166 suites. Report generated by 🧪jest coverage report action from eb24007 |
olav
reviewed
Jun 30, 2022
| exports.up = function (db, callback) { | ||
| db.runSql( | ||
| ` | ||
| ALTER TABLE features ADD archived_at date; |
There was a problem hiding this comment.
Should this use TIMESTAMP WITH TIME ZONE instead of date?
There was a problem hiding this comment.
Yes, that would align better with rest of the schema.
| const row = await this.db(TABLE) | ||
| .where({ name }) | ||
| .update({ archived: true }) | ||
| .update({ archived_at: now }) |
There was a problem hiding this comment.
Should we keep setting archived as well, while we have both columns?
There was a problem hiding this comment.
I dont think so, because we dont want to be dependant on manually setting the column. We want the archived value to be calculated always from archived_dt, so if we eventually removed archived column, then we know that everything has been working fine based on just the date column.
src/lib/db/feature-toggle-store.ts
Outdated
Comment on lines
150
to
155
| if (archived) { | ||
| queryBuilder.whereNotNull('archived_at'); | ||
| } else { | ||
| queryBuilder.whereNull('archived_at'); | ||
| } | ||
| return queryBuilder; |
There was a problem hiding this comment.
Could perhaps line up the conditions:
return archived
? queryBuilder.whereNotNull('archived_at')
: queryBuilder.whereNull('archived_at');There was a problem hiding this comment.
Sure, we can go with shortif.
| @@ -2,11 +2,10 @@ | |||
| id: events | |||
| title: /api/admin/events | |||
| --- | |||
|
|
|||
There was a problem hiding this comment.
Would revert this file, unless there are any non-formatting changes?
src/lib/types/model.ts
Outdated
| @@ -53,6 +54,7 @@ export interface FeatureToggleDTO { | |||
| export interface FeatureToggle extends FeatureToggleDTO { | |||
| project: string; | |||
| lastSeenAt?: Date; | |||
| variants?: IVariant[]; | |||
There was a problem hiding this comment.
Seems like variants should already be here, from FeatureToggleDTO.
| .expect(200) | ||
| .expect((res) => { | ||
| expect(res.body.features.length).toEqual(3); | ||
| expect(res.body.features[0].archivedAt).toBeTruthy(); |
There was a problem hiding this comment.
Could check all the features:
.expect((res) => {
expect(res.body.features.length).toEqual(3);
expect(res.body.features.every((f) => f.archived)).toEqual(true);
expect(res.body.features.every((f) => f.archivedAt)).toEqual(true);
});There was a problem hiding this comment.
Yeah, I was designing thinking in a mind that a test should usually test single functionality, but either is fine.
There was a problem hiding this comment.
Changed it to single test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
archivedAtcolumn to featuresFeatureToggleStore, which are covered byFeatureToggleStore.getAllmethodarchivedcolumn will not be used anymore, but as discussed in daily standup, not yet deleted. Will be deleted in future, if everything goes smoothly.