Remove/update references to Heroku #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I must've missed the ignore file when looking for patterns.
This seems to have been a holdover from 2020 and is probably hand-written. It has been superseded by the new autogenerated OpenAPI docs.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage reportMultiple errors occurred
Test suite run success868 tests passing in 124 suites. Report generated by 🧪jest coverage report action from d139c3d |
thomasheartman
commented
Sep 27, 2022
website/.gitignore
Outdated
| @@ -20,6 +20,6 @@ yarn-debug.log* | |||
| yarn-error.log* | |||
|
|
|||
| # OpenAPI docusaurus generated stuff | |||
| docs/reference/apis/**/sidebar.js | |||
| docs/reference/api/**/sidebar.js | |||
There was a problem hiding this comment.
This is due to a last-minute change in where we generate OpenAPI docs. This change simply makes sure the new generated docs get ignored.
Now that it's not free anymore (or won't be very shortly), let's remove it.
sighphyre
pushed a commit
that referenced
this pull request
Oct 27, 2022
## What This PR removes or updates references in the docs to Heroku. Most of the code samples have been replaced with a more generic `unleash.example.com` url, while other references have been removed or updated. Also removes old OpenAPI files that are out of date and redundant with the new generation. ## Background Come November and Heroku will no longer offer free deployments of Unleash, so it's about time we remove that claim. Links to the heroku instance are also outdated because we don't have that instance running anymore. Finally, the OpenAPI files we do have there are old and static, so they don't match the current reality. ## Commits * Meta: update ignore file to ignore autogenerated docs I must've missed the ignore file when looking for patterns. * docs: delete old openapi file. This seems to have been a holdover from 2020 and is probably hand-written. It has been superseded by the new autogenerated OpenAPI docs. * docs: add notes for heroku changes to the frontend readme and pkg * docs: remove old openapi article and add redirects to new openapi * docs: fix link in overview doc: point to GitHub instead of heroku * docs: update quickstart docs with new heroku details * docs: remove reference to crashing heroku instance * docs: remove references to herokuapp in code samples * docs: add a placeholder comment * docs: update references for heroku updates * docs: keep using unleash4 for enterprise * docs: remove start:heroku script in favor of start:sandbox * docs: remove 'deploy on heroku button' Now that it's not free anymore (or won't be very shortly), let's remove it. * docs: remove extra newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes or updates references in the docs to Heroku. Most of the code samples have been replaced with a more generic
unleash.example.comurl, while other references have been removed or updated.Also removes old OpenAPI files that are out of date and redundant with the new generation.
Background
Come November and Heroku will no longer offer free deployments of Unleash, so it's about time we remove that claim.
Links to the heroku instance are also outdated because we don't have that instance running anymore.
Finally, the OpenAPI files we do have there are old and static, so they don't match the current reality.