Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suggest remove strategy UI #2321

Merged
merged 4 commits into from Nov 3, 2022
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Nov 3, 2022

About the changes

Screenshot 2022-11-03 at 11 46 47

Suggest removing strategy in change request.

Important decisions:

  • extracted 2 dialogues for normal remove strategy and for change request for remove strategy
  • moved logic for remove strategy and suggest remove strategy into custom hooks
  • keeping everything local to avoid jumping between files. "Things that change together should be kept together" - common closure principle

Important files

Discussion points

@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 3, 2022 at 11:16AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Nov 3, 2022 at 11:16AM (UTC)

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit 1474080 into main Nov 3, 2022
@kwasniew kwasniew deleted the feat/add-delete-strategy-to-draft branch November 3, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants