-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move sso how to guides to the how-to folder #2323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2df2dc3
to
491213c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're doing the proverbial Lord's work here, Simon! 🙌🏼 This looks great, but changing the file locations also changes their URL, so you'll need to add the corresponding redirects:
Check out the plugin-client-redirects
in website/docusaurus.config.js
. Just add the old path and the new ones. Be aware that the redirects aren't active in development mode, so you'll need to use a production build to test that they work. There's more info in docusaurus' plugin-client-redirect docs.
Otherwise, I've also added suggestions to use docusaurus' admonitions for availability and deprecation notices. It's not really part of the relocation, but it might be nice to do regardless.
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Gosh that made me blush. I think it's time, yeah, if we're going to go forwards with new patterns, let's go forwards. Happy to help
Amazing, thank you! I will take a look today, I figured there was probably something I was missing here so thanks for the pointer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now 😄
I've also gone through and tested all the redirects you've added, by the way. They work as expected 🥳 |
You're amazing, thank you! |
We're in the process of moving how-to guides into the how-to folder, where they belong. This continues that work and shifts the how to guides for SSO to the correct place and gives them appropriate names