Update environments #2339
Merged
Update environments #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sighphyre
reviewed
Nov 10, 2022
nunogois
force-pushed
the
update-environments
branch
from
50f24c0
to
0639a62
Compare
sighphyre
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
@nunogois This is nice, but I was tempted to reject based on the size of the PR. Please try to break up the PR size into chunks in the future. It's much easier to review, and we lower the risk of introducing bugs because the reviewer can more easily reason about the code and take in the entire context of the PR. It was difficult for me to do that here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-357/update-environments-pages