feat: suggest strategy from template #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Tymek
requested review from
andreas-unleash,
sjaanus,
FredrikOseberg and
kwasniew
kwasniew
approved these changes
Nov 8, 2022
| onAfterAddStrategy: () => void; | ||
| } | ||
|
|
||
| export const AddFromTemplateCard: FC<IAddFromTemplateCardProps> = ({ |
There was a problem hiding this comment.
I'd consider adding PresetCard as {children} to avoid prop-drilling title, children, stretegy, Icon, onAfterAddStrategy. More info about this technique: https://www.youtube.com/watch?v=3XaXKiXtNjw&ab_channel=ReactTraining
There was a problem hiding this comment.
I got rid of PresetCard, embedded the code in parent. At this point it was just styling. I couldn't entirely move it to {children} because of onClick action handler.
...ent/feature/FeatureStrategy/FeatureStrategyEmpty/AddFromTemplateCard/AddFromTemplateCard.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Add "change request" to buttons in empty environment - adding with "Use template".
Closes 1-348/add-strategy-to-draft-with-use-template
Important files
frontend/src/component/feature/FeatureStrategy/FeatureStrategyEmpty/FeatureStrategyEmpty.tsxDiscussion points