Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changeRequestEnabled to project and project_environments #2357

Merged
merged 7 commits into from Nov 9, 2022
Merged

Add changeRequestEnabled to project and project_environments #2357

merged 7 commits into from Nov 9, 2022

Conversation

andreas-unleash
Copy link
Contributor

@andreas-unleash andreas-unleash commented Nov 9, 2022 •
edited

  • Add change_request_enabled column to projects and project_environments
  • Modified the store to include the new column
  • Added new column to Project open api schema

About the changes

Closes #

Important files

Discussion points

@vercel
Copy link

vercel bot commented Nov 9, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Nov 9, 2022 at 0:16AM (UTC)
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Nov 9, 2022 at 0:16AM (UTC)

@andreas-unleash andreas-unleash changed the title Add changeRequestEnabled to project Add changeRequestEnabled to project and project_environments Nov 9, 2022
@andreas-unleash andreas-unleash marked this pull request as ready for review November 9, 2022 12:32
kwasniew
kwasniew approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One question: do we need this at both the project level and project_environment level?

@andreas-unleash
Copy link
Contributor Author

I think so, so an admin can enable Change requests for the project and still be able to disable them for eg `development`` env

@andreas-unleash andreas-unleash merged commit 47a617c into main Nov 9, 2022
@andreas-unleash andreas-unleash deleted the feat/change-request-project-options branch November 9, 2022 12:44
andreas-unleash added a commit that referenced this pull request Nov 10, 2022
@andreas-unleash
Revert "Add changeRequestEnabled to project and project_environments (#…
a908c85 
…2357)"

This reverts commit 47a617c.
@andreas-unleash andreas-unleash mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwasniew kwasniew kwasniew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreas-unleash @kwasniew