Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop making enterprise calls in oss #2449

Merged
merged 2 commits into from Nov 17, 2022
Merged

stop making enterprise calls in oss #2449

merged 2 commits into from Nov 17, 2022

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Nov 16, 2022 •
edited

About the changes

We were fetching change request config and change request status in OSS version. This PR stops this behavior.

Design decisions:

  • keep the change surface area small - don't touch most of the existing code
  • make fetcher return a fallback value for OSS

Important files

Discussion points

@vercel
Copy link

vercel bot commented Nov 16, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 17, 2022 at 8:35AM (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 17, 2022 at 8:35AM (UTC)

@kwasniew kwasniew requested review from andreas-unleash, Tymek, sjaanus and FredrikOseberg and removed request for Tymek November 16, 2022 12:08
FredrikOseberg
FredrikOseberg approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe we could make an abstraction in the future, this will probably happen again. But for now, this is simple enough.

@kwasniew kwasniew merged commit f2dde9d into main Nov 17, 2022
@kwasniew kwasniew deleted the fetcher-fallback-for-oss branch November 17, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

@andreas-unleash andreas-unleash Awaiting requested review from andreas-unleash

@sjaanus sjaanus Awaiting requested review from sjaanus

@Tymek Tymek Awaiting requested review from Tymek

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwasniew @FredrikOseberg