Feat update token seen at #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nunogois
force-pushed
the
feat-update-token-seen-at
branch
from
ed33001
to
59ee757
Compare
gastonfournier
approved these changes
Nov 28, 2022
ivarconr
reviewed
Nov 28, 2022
ivarconr
reviewed
Nov 28, 2022
| @@ -52,10 +53,16 @@ export class ApiTokenService { | |||
|
|
|||
| private timer: NodeJS.Timeout; | |||
|
|
|||
| private seenTimer: NodeJS.Timeout; | |||
There was a problem hiding this comment.
We could have made the precious timer in to an array, we only need to keep the reference to be able to clear them all.
There was a problem hiding this comment.
Hmm I'm not sure I understood this one, could you please clarify?
I guess they could both be inside a NodeJS.Timeout[] but if we want a single reference to each we would store them in [0] and [1] I guess? 🤔 Besides one of them is an interval and the other a timeout.
Seems like decreased readability without much to gain, so I'm probably missing something.
ivarconr
reviewed
Nov 28, 2022
Co-authored-by: Ivar Conradi Østhus <ivar@getunleash.ai>
Co-authored-by: Ivar Conradi Østhus <ivar@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-448/update-last-seen-column-for-api-tokens