New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: favorite feature table icons #2525
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking approve but please check comments
frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx
Outdated
Show resolved
Hide resolved
import { useMemo, useState } from 'react'; | ||
import { sortTypes } from 'utils/sortTypes'; | ||
|
||
const sortTypesWithFavorites = Object.fromEntries( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit test to describe how to use it
frontend/src/component/feature/FeatureToggleList/FavoriteIconCell/FavoriteIconCell.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
About the changes
Closes linear 1-403