Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: favorite feature table icons #2525

Merged
merged 9 commits into from Nov 30, 2022
Merged

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Nov 24, 2022

About the changes

image

Closes linear 1-403

@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 30, 2022 at 0:40AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Nov 30, 2022 at 0:40AM (UTC)

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking approve but please check comments

import { useMemo, useState } from 'react';
import { sortTypes } from 'utils/sortTypes';

const sortTypesWithFavorites = Object.fromEntries(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test to describe how to use it

frontend/src/hooks/usePinnedFavorites.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tymek Tymek enabled auto-merge (squash) November 30, 2022 12:43
@Tymek Tymek merged commit 5f88269 into main Nov 30, 2022
@Tymek Tymek deleted the feat/favorite-features-frontend branch November 30, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants