New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plausible events for favorite features #2579
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@@ -172,7 +173,7 @@ export const FeatureToggleListTable: VFC = () => { | |||
accessor: 'description', | |||
}, | |||
], | |||
[isFavoritesPinned] | |||
[isFavoritesPinned, uiConfig?.flags?.favorites] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed a small bug, that favorites were not updating, due to missing dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One weird track event in the error catch block
@@ -51,6 +58,11 @@ export const useFavoriteFeaturesApi = () => { | |||
title: 'Toggle removed from favorites', | |||
type: 'success', | |||
}); | |||
trackEvent('favorite', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have this event in the catch block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is in try block. Hmm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry weird github formatting
No description provided.