Feat/add enterprise badge to change req settings #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
…ings # Conflicts: # frontend/src/component/project/Project/ProjectSettings/ChangeRequestConfiguration/ChangeRequestConfiguration.tsx # frontend/src/hooks/usePlausibleTracker.ts
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Tymek
approved these changes
Dec 2, 2022
Tymek
reviewed
Dec 2, 2022
...nt/project/Project/ProjectSettings/ChangeRequestConfiguration/ChangeRequestConfiguration.tsx
Outdated
Show resolved
Hide resolved
Tymek
reviewed
Dec 2, 2022
| const { hasAccess } = useContext(AccessContext); | ||
| const { isOss, uiConfig } = useUiConfig(); | ||
| const isPro = !( | ||
| Boolean(uiConfig.versionInfo?.current.oss) || |
There was a problem hiding this comment.
Would be nice to have this in a reusable hook or util: const { isOss, isPro, isEnteprise } = usePlan() or something. There's also useInstanceStatus.
There was a problem hiding this comment.
Here's something that may help: #2600
Tymek
reviewed
Dec 2, 2022
| { | ||
| Header: 'Required approvals', | ||
| align: 'center', | ||
| Cell: ({ row: { original } }: any) => { |
There was a problem hiding this comment.
maybe this can be extracted to a component
There was a problem hiding this comment.
Agreed, just moved the implementation for the moment, but it could use some cleanup
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
…equestConfiguration/ChangeRequestConfiguration.tsx Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
…nge_req_settings' into feat/add_enterprise_badge_to_change_req_settings
nunogois
requested changes
Dec 2, 2022
frontend/src/component/common/ProFeatureTooltip/ProFeatureTooltip.tsx
Outdated
Show resolved
Hide resolved
frontend/src/component/common/ProFeatureTooltip/ProFeatureTooltip.tsx
Outdated
Show resolved
Hide resolved
frontend/src/component/common/ProFeatureTooltip/ProFeatureTooltip.tsx
Outdated
Show resolved
Hide resolved
frontend/src/component/common/ProFeatureTooltip/ProFeatureTooltip.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Dec 2, 2022
frontend/src/component/common/VerticalTabs/VerticalTab/VerticalTab.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Dec 2, 2022
nunogois
reviewed
Dec 2, 2022
frontend/src/component/project/Project/ProjectSettings/ProjectSettings.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Dec 2, 2022
nunogois
reviewed
Dec 2, 2022
…Settings.tsx Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
nunogois
reviewed
Dec 2, 2022
...nt/project/Project/ProjectSettings/ChangeRequestConfiguration/ChangeRequestConfiguration.tsx
Show resolved
Hide resolved
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
…nge_req_settings' into feat/add_enterprise_badge_to_change_req_settings # Conflicts: # frontend/src/component/project/ProjectAccess/ProjectAccess.tsx
nunogois
reviewed
Dec 5, 2022
frontend/src/component/common/PremiumFeature/PremiumFeature.tsx
Outdated
Show resolved
Hide resolved
frontend/src/component/common/PremiumFeature/PremiumFeature.tsx
Outdated
Show resolved
Hide resolved
frontend/src/component/project/Project/ProjectSettings/ProjectSettings.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
@andreas-unleash I need to double check the messages with Elise and come back with a final version, so you know that we will need another small PR for this But other than this it looks super nice 👍 |
andreas-unleash
deleted the
feat/add_enterprise_badge_to_change_req_settings
branch
nunogois
added a commit
that referenced
this pull request
Dec 6, 2022
Hopefully a cleaner and DRY way of checking for the current Unleash plan level, which may help in cases like #2585 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable change requests for Pro and oss
About the changes
Closes #
Important files
Discussion points