[feat] export features with variants event when feature is disabled #2719
Conversation
|
@matlockx is attempting to deploy a commit to the unleash-team Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Hi @matlockx! Thanks for opening this PR! I'm not completely sure why, it might just be something we overlooked. But let me talk about it with the team next week to confirm. From the top of my mind, this makes sense. |
|
Hi @matlockx sorry about the delay, I've opened another PR #2824 to add tests which confirm the misbehaviour: https://github.com/Unleash/unleash/actions/runs/3838645588/jobs/6535361951#step:5:392 and merged your change on top which confirms fixing the issue: https://github.com/Unleash/unleash/actions/runs/3838676975. I'll continue with that one (cause I can't update your PR) and add you as co-author. |
|
👍 |
) ## About the changes When exporting features one is normally also interested in disabled features, so they are also included in the export file, while the variants are not. I do not see a good reason for that, so this PR removes the check and exports the variants then as well. I could also add an option as well, but as long as there is no good reason for ignoring the variants I would just export them with the features. This PR adds tests on #2719 Closes #2719 Co-authored-by: Martin Joehren <martin.joehren@esailors.de>
) ## About the changes When exporting features one is normally also interested in disabled features, so they are also included in the export file, while the variants are not. I do not see a good reason for that, so this PR removes the check and exports the variants then as well. I could also add an option as well, but as long as there is no good reason for ignoring the variants I would just export them with the features. This PR adds tests on #2719 Closes #2719 Co-authored-by: Martin Joehren <martin.joehren@esailors.de>
About the changes
When exporting features one is normally also interested in disabled features, so they are also included in the export file, while the variants are not. I do not see a good reason for that, so this PR removes the check and exports the variants then as well.
I could also add an option as well, but as long as there is no good reason for ignoring the variants I would just export them with the features.