Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Project meta widget #2995

Merged
merged 8 commits into from
Jan 27, 2023
Merged

feat: Project meta widget #2995

merged 8 commits into from
Jan 27, 2023

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Jan 25, 2023

About the changes

image

Closes issue/1-585

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 11:56AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Jan 27, 2023 at 11:56AM (UTC)

@Tymek Tymek changed the title Feat/project meta widget feat: Project meta widget Jan 25, 2023
}
elseShow={
<Typography variant="body2" textAlign="center">
<Link component={RouterLink} to="./edit">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about single source of truth for links so that they never get out of sync?

import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';

interface IMetaWidgetProps {
id?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can id be undefined?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during loading

frontend/src/component/project/Project/Project.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@andreas-unleash andreas-unleash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants