Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove all warnings #3055

Merged
merged 2 commits into from
Feb 7, 2023
Merged

fix: remove all warnings #3055

merged 2 commits into from
Feb 7, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Feb 7, 2023

About the changes

Fixing all warnings. The point is with 50+ warnings those are ignored.

Important:

  • removed exhaustive react deps check as we ignore them anyway
  • one logical condition fix
  • using ===
  • removed unused vars

Important files

Discussion points

@vercel
Copy link

vercel bot commented Feb 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 8:16AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Feb 7, 2023 at 8:16AM (UTC)

@kwasniew kwasniew merged commit 377e0e9 into main Feb 7, 2023
@kwasniew kwasniew deleted the fix-all-warnings branch February 7, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants