chore: make event store accept IUser #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
gastonfournier
commented
Feb 10, 2023
src/lib/types/events.ts
Outdated
Comment on lines
145
to
146
| typeof createdBy === 'string' || typeof createdBy === 'undefined' | ||
| ? createdBy |
There was a problem hiding this comment.
This maintains the same behaviour as before, if createdBy is passed as undefined we propagate that (which should break DB constraints and display an error)
gastonfournier
commented
Feb 21, 2023
| this.createdBy = | ||
| typeof createdBy === 'string' | ||
| ? createdBy | ||
| : extractUsernameFromUser(createdBy); |
There was a problem hiding this comment.
Reusing an existing function: https://github.com/Unleash/unleash/blob/03c34995466ab8f13f188c588b28c8d74c819c49/src/lib/util/extract-user.ts
|
After enabling strictNullChecks this PR would be increasing the number of null check errors from 498 to 499. Make sure your branch is up-to-date with main and check the diff in the console output to gather more details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Currently, we need to remember of using the email or else the username of a user when storing into EventStore, because we don't have strictNullChecks, it's error-prone. Fix for a production issue: #3072
I tried enabling strictNullChecks in our tsconfig file, but it reports 509 issues in 143 files.
This means we also need to check for undefined here:
unleash/src/lib/types/events.ts
Lines 144 to 147 in 479d2f1