Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export segments limited info #3109

Merged
merged 3 commits into from Feb 14, 2023
Merged

Export segments limited info #3109

merged 3 commits into from Feb 14, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Feb 14, 2023 •
edited

About the changes

  • we don't need to export whole segments, only id and name are needed for importing. It can save a lot of kB since segments can have very long lists of contraints
  • also fixing error message because the previous one was too specific for cover all suberrors

Important files

Discussion points

@vercel
Copy link

vercel bot commented Feb 14, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 2:18PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Feb 14, 2023 at 2:18PM (UTC)

@kwasniew kwasniew merged commit b1728c5 into main Feb 14, 2023
@kwasniew kwasniew deleted the export-segments-limited-info branch February 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaanus sjaanus sjaanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwasniew @sjaanus