Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial UI draft #3191

Merged
merged 2 commits into from Feb 24, 2023
Merged

fix: initial UI draft #3191

merged 2 commits into from Feb 24, 2023

Conversation

FredrikOseberg
Copy link
Contributor

Initial draft for notifications UI behind a feature flag. I'd like to get this merged because the PR is cluttered by open api generation. In the next PR I will:

  • Clean up the SX and introduce styled components
  • Add a component for single notifications and implement the notification list

Skjermbilde 2023-02-24 kl  11 07 43

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 10:21AM (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 10:21AM (UTC)

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some unrelated schemas have relaxed the constraints. This should be ok

export const Notifications = () => {
const { notifications } = useNotifications({ refreshInterval: 15 });

console.log(notifications);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log can be remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm still using it. It will be removed in the followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants