feat: display sign on log #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gastonfournier
approved these changes
Feb 27, 2023
| @@ -10,19 +10,23 @@ interface ITimeAgoCellProps { | |||
| live?: boolean; | |||
| emptyText?: string; | |||
| title?: (date: string) => string; | |||
| timestamp?: boolean; | |||
There was a problem hiding this comment.
What about receiving the format function as with the title?
Suggested change
| timestamp?: boolean; | |
| dateFormat?: (value?: string | number | Date, locale?: string) => string; |
Because timestamp as a boolean limits you to have 2 formats, if you want to add a third one things gets complicated. If the function is not provided you just use the default formatting function:
const fn = dateFormat || formatDateYMD;
const date = fn(value, locationSettings.locale);| Header: 'Created', | ||
| accessor: 'created_at', | ||
| Cell: ({ value }: { value: Date }) => ( | ||
| <TimeAgoCell value={value} timestamp /> |
There was a problem hiding this comment.
With the change suggested this would become:
<TimeAgoCell value={value} dateFormat={formatDateYMDHMS} />
|
Thanks @gastonfournier, I think this is a great optimization for |
nunogois
added a commit
that referenced
this pull request
Feb 27, 2023
Slight refactor to `TimeAgoCell` that allows passing in a date format function. Suggested by @gastonfournier in #3193 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
https://linear.app/unleash/issue/2-719/display-basic-sign-on-log-in-frontend
Adds a basic, naïve way of displaying sign-on history.
We can be OK with merging this for now if we want, given that it's behind a feature flag, and then iterate over it and implement the features and improvements we need in the meantime.
Relates to roadmap item: #2951