Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update change requests permissions docs #3194

Merged
merged 1 commit into from Feb 27, 2023

Conversation

thomasheartman
Copy link
Contributor

This change updates the "change requests permissions" section of the change request doc to explicitly call out a few things we've seen confusion around recently.

These are:

  • project owners can't approve/apply change requests. You must create custom roles
  • viewers can create change requests. This is intentional
  • skip change requests only works via the API

It also:

  • elaborates a little on the circumventing change requests section to clarify how it works.
  • adds the change requests project roles to the project roles list. This section should be kept up to date with all the relevant roles that exist for projects.

This change updates the "change requests permissions" section of the
change request doc to explicitly call out a few things we've seen
confusion around recently.

These are:
- project owners can't approve/apply change requests. You must create
custom roles
- viewers can create change requests. This is intentional
- skip change requests only works via the API

It also:
- elaborates a little on the circumventing change requests section to
clarify how it works.
- adds the change requests project roles to the project roles list.
This section should be kept up to date with all the relevant roles
that exist for projects.
@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 7:39AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Feb 27, 2023 at 7:39AM (UTC)

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good explanation

@thomasheartman thomasheartman merged commit e7ef06f into main Feb 27, 2023
@thomasheartman thomasheartman deleted the docs/change-requests-2 branch February 27, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants