feat: implement plausible tracking #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
approved these changes
Feb 28, 2023
|
|
||
| const onNotificationClick = (notification: NotificationsSchemaItem) => { | ||
| if (notification.link) { | ||
| navigate(notification.link); | ||
| } | ||
|
|
||
| if (uiConfig?.flags?.T) { |
There was a problem hiding this comment.
do we need this flag if notifications are not even shown without this flag enabled?
There was a problem hiding this comment.
Yes, because we only want to track in the context of our cloud offering where tracking is available for us. For OSS and Enterprise-self hosted, this is not the case. I'd rather add the flag now, then to forget about it when we go to production. This flag will be true when we have access to plausible, it doesn't control the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds plausible event tracking for notifications. Refactors Feedback component to be reusable and to ask whether or not this functionality is useful.