Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass shared event store #3233

Merged
merged 2 commits into from Mar 1, 2023
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Mar 1, 2023

About the changes

Pass event store around for event emitter semantics. This will fix import not triggering notifications

Important files

Discussion points

@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-docs 🔄 Building (Inspect) Mar 1, 2023 at 1:07PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Mar 1, 2023 at 1:07PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

After enabling strictNullChecks this PR would be increasing the number of null check errors from 500 to 502.
Make sure your branch is up-to-date with main and check the diff in the console output to gather more details.

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit ad588fd into main Mar 1, 2023
@kwasniew kwasniew deleted the propagate-event-store-to-import branch March 1, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants