Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename sign-on log to login history #3245

Merged
merged 3 commits into from Mar 2, 2023
Merged

refactor: rename sign-on log to login history #3245

merged 3 commits into from Mar 2, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Mar 2, 2023

Renames sign-on log to login history.

@vercel
Copy link

vercel bot commented Mar 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 1:42PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Mar 2, 2023 at 1:42PM (UTC)

thomasheartman
thomasheartman reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me. Is the login history an experimental thing (I see it's listed under types/experimental)? If not, we'll need to maintain the previous endpoint too.

@nunogois
Copy link
Member Author

nunogois commented Mar 2, 2023 •
edited

This looks pretty good to me. Is the login history an experimental thing (I see it's listed under types/experimental)? If not, we'll need to maintain the previous endpoint too.

Yep, it is behind a flag currently and it always has been since we're still in early stages of the project (no BETA yet), so no need to worry about breaking changes here.

gastonfournier
gastonfournier approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@nunogois nunogois merged commit ea83849 into main Mar 2, 2023
@nunogois nunogois deleted the refactor-rename-sign-on-log branch March 2, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasheartman thomasheartman thomasheartman left review comments

@gastonfournier gastonfournier gastonfournier approved these changes

@chriswk chriswk Awaiting requested review from chriswk

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nunogois @gastonfournier @thomasheartman