chore: re-use the same client schema for proxy #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
client-metrics-schema is less strict than proxy-metrics-schema because the former allows empty
instanceIdand also supports dates as timestamps as well as date-formatted strings.Using the same schema makes sense to reduce maintainability costs and it's less error-prone if we need to modify the schema because underlying the schema they both use the same code.
The reasoning is that proxy metrics should align with our client metrics. Alternatively, we have new endpoints for edge metrics that will aggregate and bucket by client.
Discussion points
Will we ever want to evolve proxy-metrics differently than client-metrics? I'm under the assumption that the answer is no