Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor segments to stop depending on the implementation #3315

Merged
merged 6 commits into from Mar 15, 2023
Merged

chore: refactor segments to stop depending on the implementation #3315

merged 6 commits into from Mar 15, 2023

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Mar 15, 2023 •
edited

About the changes

  • Introducing ISegmentService interface to decouple from the actual implementation
  • Moving UpsertSegmentSchema to OSS to be able to use types
  • Added comments where our code is coupled with segments just to highlight and have a conversation about some use cases if needed, but they can be removed before merging
  • Removed segment service from some project features as it was not used

@vercel
Copy link

vercel bot commented Mar 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Mar 15, 2023 at 10:31AM (UTC)
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2023 at 10:31AM (UTC)

gastonfournier
gastonfournier commented Mar 15, 2023
View reviewed changes
src/lib/services/feature-toggle-service.ts
Comment on lines +355 to +358
if (
strategyConfig.constraints &&
strategyConfig.constraints.length > 0
) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the compiler happier

@gastonfournier gastonfournier self-assigned this Mar 15, 2023
chriswk
chriswk approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, I like the separation into a new upsert schema. :)

@gastonfournier
Copy link
Contributor Author

I think this looks good, I like the separation into a new upsert schema. :)

Thanks! this was already present in enterprise

@gastonfournier gastonfournier merged commit 1d0bc83 into main Mar 15, 2023
6 checks passed
@gastonfournier gastonfournier deleted the improvements-segments-migration branch March 15, 2023 13:58
gastonfournier added a commit that referenced this pull request Mar 15, 2023
@gastonfournier
Follow ups on #3315
6f0a0c7
@gastonfournier gastonfournier mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk chriswk approved these changes

Assignees

@gastonfournier gastonfournier

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gastonfournier @chriswk