fix: remove stickiness error #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
andreas-unleash
requested changes
Mar 16, 2023
| style={{ | ||
| width: 'inherit', | ||
| minWidth: '100%', | ||
| marginBottom: '16px', |
There was a problem hiding this comment.
This could/should be expressed with theme.spacing for consistency
There was a problem hiding this comment.
sx is not supported on this component
| status: res.status, | ||
| body: await res.json(), | ||
| }; | ||
| const fetcher = (path: string) => { |
There was a problem hiding this comment.
Why was this refactoring necessary?
There was a problem hiding this comment.
to match code of the other fetchers I've seen. We don't expose the status normally and we also keep fetcher private to the hook
There was a problem hiding this comment.
you can check useChangeRequest for comparison
andreas-unleash
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Code was failing on create project because project id is empty
Important files
Discussion points