Feat: plausible tracking stickiness #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
andreas-unleash
changed the title
kwasniew
approved these changes
Mar 21, 2023
| @@ -10,6 +12,7 @@ import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; | |||
| import useToast from 'hooks/useToast'; | |||
| import { formatUnknownError } from 'utils/formatUnknownError'; | |||
| import { GO_BACK } from 'constants/navigate'; | |||
| import { usePlausibleTracker } from '../../../../hooks/usePlausibleTracker'; | |||
| import useProjectForm from '../hooks/useProjectForm'; | ||
| import useProjectForm, { | ||
| DEFAULT_PROJECT_STICKINESS, | ||
| } from '../hooks/useProjectForm'; |
| @@ -15,6 +17,7 @@ import AccessContext from 'contexts/AccessContext'; | |||
| import { Alert } from '@mui/material'; | |||
| import { GO_BACK } from 'constants/navigate'; | |||
| import { useDefaultProjectSettings } from 'hooks/useDefaultProjectSettings'; | |||
| import { usePlausibleTracker } from '../../../../hooks/usePlausibleTracker'; | |||
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
Initially I was planning to use it within a useEffect, but that would give false results if someone is changing the select over and over. Having it in the submit handler, ensures we only track what we need |
# Conflicts: # frontend/src/hooks/api/actions/useProjectApi/useProjectApi.ts # frontend/src/hooks/usePlausibleTracker.ts
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds plausible tracking when default project stickiness is changed
About the changes
Closes #
Important files
Discussion points