Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header-responsiveness #3381

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: header-responsiveness #3381

merged 1 commit into from
Mar 24, 2023

Conversation

nicolaesocaciu
Copy link
Contributor

@nicolaesocaciu nicolaesocaciu commented Mar 24, 2023

  • when introducing dark mode icon in the header, above 960px, the menu items don't have enough space anymore, and this fix it

  • fixing also the color for dark mode of the keyboard nav button "skip to content"

- when introducing dark mode icon in the header, on tablet the menu items don't have enough space anymore, and this fix it

- fixing also the color for dark mode of the keyboard nav button "skip to content"
@vercel
Copy link

vercel bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Mar 24, 2023 at 11:56AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
unleash-docs ⬜️ Ignored (Inspect) Mar 24, 2023 at 11:56AM (UTC)

[theme.breakpoints.down('md')]: {
padding: '0',
},
'&&&': { padding: 0 },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i used this method because there is some styling that is applied to this component and overwrites a normal padding

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolaesocaciu nicolaesocaciu merged commit 3e602ce into main Mar 24, 2023
@nicolaesocaciu nicolaesocaciu deleted the fix-header-responsiveness branch March 24, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants