fix error boundary #3389
Merged
fix error boundary #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Mar 27, 2023
| <Routes> | ||
| {availableRoutes.map(route => ( | ||
| <PlausibleProvider> | ||
| <ErrorBoundary FallbackComponent={Error}> |
There was a problem hiding this comment.
this will catch all the unhandled errors except from the plausible errors
kwasniew
commented
Mar 27, 2023
| @@ -48,61 +48,67 @@ export const App = () => { | |||
|
|
|||
| return ( | |||
| <ErrorBoundary FallbackComponent={Error}> | |||
There was a problem hiding this comment.
this is to handle plausible errors from the plausible provider
kwasniew
requested review from
nunogois,
gastonfournier,
FredrikOseberg and
Tymek
Tymek
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Move plausible available for the error boundary.
Previously:
After:
This is just a few LOC but the formatting kicked in
Important files
Discussion points