Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PAT kill switch #3454

Merged
merged 5 commits into from Apr 5, 2023
Merged

feat: add PAT kill switch #3454

merged 5 commits into from Apr 5, 2023

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Apr 4, 2023

Add the ability to disable Personal Access Tokens (PAT) admin API

This PR disables PAT admin endpoints so it's not possible to create or get PATs the kill switch is enabled, the UI is hidden but the existing PATs will continue to work if they were created before. The delete endpoint still works allowing an admin to delete old PATs

By default the kill switch is disabled (i.e. PAT is enabled by default)

@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 8:09am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Apr 5, 2023 8:09am

@gastonfournier gastonfournier marked this pull request as ready for review April 4, 2023 15:12
@gastonfournier gastonfournier self-assigned this Apr 4, 2023
@gastonfournier gastonfournier changed the title Pat kill switch alternative feat: add PAT kill switch Apr 5, 2023
@gastonfournier gastonfournier merged commit 0e37e68 into main Apr 5, 2023
18 checks passed
@gastonfournier gastonfournier deleted the pat-kill-switch-alternative branch April 5, 2023 08:20
gastonfournier added a commit that referenced this pull request Apr 5, 2023
This PR disables PAT admin endpoints so it's not possible to create or
get PATs the kill switch is enabled, the UI is hidden but the existing
PATs will continue to work if they were created before. The delete
endpoint still works allowing an admin to delete old PATs

By default the kill switch is disabled (i.e. PAT is enabled by default)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants