Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to node 18 #3527

Merged
merged 12 commits into from Apr 18, 2023
Merged

chore: update to node 18 #3527

merged 12 commits into from Apr 18, 2023

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Apr 14, 2023

About the changes

This upgrades our main branch to use node 18 which is the active LTS version and stops using node 14 which reaches the end of life in a few weeks: https://nodejs.dev/en/about/releases/

This PR also adds --no-experimental-fetch for frontend tests and other frontend commands. Related to: node-fetch/node-fetch#1566

More about the experimental fetch release: https://nodejs.org/en/blog/announcements/v18-release-announce#fetch-experimental

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 8:22am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Apr 18, 2023 8:22am

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Node Next (v20) is due out today, so let's stick with only 18 for now. :)

@gastonfournier gastonfournier merged commit 0426dd5 into main Apr 18, 2023
16 checks passed
@gastonfournier gastonfournier deleted the v5-node-18 branch April 18, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants