Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: root roles from groups #3559

Merged
merged 19 commits into from Apr 20, 2023
Merged

feat: root roles from groups #3559

merged 19 commits into from Apr 20, 2023

Conversation

sighphyre
Copy link
Member

What

This allows the option setting a root role on a group (only Editor or Admin). Any user that enters that group will receive the permissions from that root role but will not have their base root role changed. This property is allowed to be undefined so that we have a little layer of backwards compatibility and the db migration shouldn't impact the code flow whether or not the feature is enabled.

Relevant Decisions

  • Users entering a group with a root role take on that role without needing to be added to a project directly
  • On the backbone of the above, groups with root roles cannot be added directly to a project, this is to prevent confusion
  • The base role of users is unaffected by entering a group with a root role - they will still reflect as Viewer/Editor/Admin in the user information screen, but they will have the permissions from the group root role

Screens

Modifications to group add/edit screen

image

Displaying relevant properties on the group. Each group is tagged with a root role description if present. Groups with root roles will not display "not used".

image

Changes to add user/group to project - if a group has a root role it can't be added directly to a project

image

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 9:29am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 20, 2023 9:29am

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job with this, left a few optional comments.

I'm a bit confused with the feature if I'm completely honest. If you're adding to the documentation I wouldn't mind having a look as well just to see if I get a better understanding of it.

It also makes me feel like we urgently need some kind of permission matrix or similar system to easily see all the permissions each user has access to. I imagine it can be very confusing for a user to have higher access but to see it on the users page as Viewer and not understanding exactly where that access is coming from.

Co-authored-by: Nuno Góis <github@nunogois.com>
…gn/ProjectAccessAssign.tsx

Co-authored-by: Nuno Góis <github@nunogois.com>
sighphyre and others added 2 commits April 20, 2023 08:25
…Card.tsx

Co-authored-by: Nuno Góis <github@nunogois.com>
…gn/ProjectAccessAssign.tsx

Co-authored-by: Nuno Góis <github@nunogois.com>
@sighphyre
Copy link
Member Author

Amazing job with this, left a few optional comments.

I'm a bit confused with the feature if I'm completely honest. If you're adding to the documentation I wouldn't mind having a look as well just to see if I get a better understanding of it.

It also makes me feel like we urgently need some kind of permission matrix or similar system to easily see all the permissions each user has access to. I imagine it can be very confusing for a user to have higher access but to see it on the users page as Viewer and not understanding exactly where that access is coming from.

Appreciate the feedback sir! Docs are en route, but haven't been done yet. Happy to chat before then though because I do agree, we have a ton of ways that a user can have a permissions modified and it's getting hella confusing at this point. I think we need these changes to serve some of our users with large sets of users that are painful to manage but this is definitely adding fuel to an already burning fire. It'd be nice if we head that off at the pass before we start getting bombarded with help requests because people don't understand why permissions are behaving the way they are

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes

@sighphyre sighphyre merged commit 3b42e86 into main Apr 20, 2023
16 checks passed
@sighphyre sighphyre deleted the feat/root-roles-from-groups branch April 20, 2023 10:29
@sighphyre
Copy link
Member Author

Related to #3539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants