Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add demo guide welcome dialog #3574

Merged
merged 3 commits into from Apr 20, 2023
Merged

feat: add demo guide welcome dialog #3574

merged 3 commits into from Apr 20, 2023

Conversation

nunogois
Copy link
Member

https://linear.app/unleash/issue/2-923/add-initial-getting-started-dialog

Adds the welcome dialog with the static QR code pointing to our demo website. Also changes how the run logic works a bit, so that we have better control over it (only start demo steps once we click the start button, etc).

Relates to roadmap item: #3537

image

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 2:52pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Apr 20, 2023 2:52pm

@nunogois nunogois changed the title feat: add welcome dialog, refactor run logic feat: add demo welcome dialog Apr 20, 2023
@nunogois nunogois changed the title feat: add demo welcome dialog feat: add demo guide welcome dialog Apr 20, 2023
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +23 to +24
const [welcomeOpen, setWelcomeOpen] = useState(
storedProgress.welcomeOpen ?? true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this reset every time we deploy a new version? I don't remember how storedProgress is persisted, but I just thought asking the question

Copy link
Member Author

@nunogois nunogois Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's persisted on local storage, I don't think deploying new versions of Unleash would affect it.

This local storage set is also versioned as Tutorial:v1, so if we later release a new version of the tutorial and want to reset it for end-users we just need to increase this version.

Users have the choice of re-entering the welcome screen at any point through the topic list by clicking "View demo link again" at the bottom of the list:
image
Clicking any of the topics at any point would start that topic as well.

@nunogois nunogois merged commit 2cf6e68 into main Apr 20, 2023
16 checks passed
@nunogois nunogois deleted the feat-demo-welcome-dialog branch April 20, 2023 15:32
nunogois added a commit that referenced this pull request Apr 21, 2023
https://linear.app/unleash/issue/2-925/add-final-tutorial-complete-dialog

Adds the finish dialog, similar to
#3574

Also includes some fixes and improvements identified in the meantime.

Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#3537


![image](https://user-images.githubusercontent.com/14320932/233421564-447c559b-db70-4f72-a1d2-b6b5bef3707f.png)

---------

Co-authored-by: Gastón Fournier <gaston@getunleash.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants