Disable and enable strategies - frontend #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tymek
commented
Apr 21, 2023
•
Tymek
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
filter out disabled strategies Signed-off-by: andreas-unleash <andreas@getunleash.ai>
filter out disabled strategies by default. return disabled strategies for the UI and the playground Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Tymek
force-pushed
the
feat/disable-strategy-frontend
branch
from
133d25d
to
600fe25
Compare
kwasniew
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Very nice.
A few non blocking comments:
- I'd add the 2 new flags to our hosted instance (even before you start work on a new feature)
- Disabling last strategy doesn't disable a toggle - is it by design?
- For all new code I write I try to increase test coverage. Maybe after merging this PR try to add at least one cypress tests for the Change Request user journey?
- In future PRs I'd split logical changes like changing a title and disabling strategy at least into 2 separate PRs if not more. It makes it easier for the reviewers.
@kwasniew we agreed to avoid adding Cypress tests for the use cases that are not essential to the core functionality of the application. These tests tend to have a high maintenance overhead and can be flaky, which diminishes their value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.