Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up old errors #3633

Merged
merged 29 commits into from
May 11, 2023
Merged

Clean up old errors #3633

merged 29 commits into from
May 11, 2023

Commits on May 8, 2023

  1. Chore: convert password mismatch to UnleashError

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    1a40991 View commit details
    Browse the repository at this point in the history

  2. chore: update roleinuseerror

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    816f843 View commit details
    Browse the repository at this point in the history

  3. chore: update remaining errors

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    e582203 View commit details
    Browse the repository at this point in the history

  4. Fix: doesn't double punctuation

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    45d2604 View commit details
    Browse the repository at this point in the history

  5. Chore: write tests for all non-standard error types

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    5e433f8 View commit details
    Browse the repository at this point in the history

  6. chore: make authenticationrequired an UnleashError subclass

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    47201b9 View commit details
    Browse the repository at this point in the history

  7. Wip: update some tests

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    010b97d View commit details
    Browse the repository at this point in the history

  8. Chore : Move some types around:

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    60fc243 View commit details
    Browse the repository at this point in the history

  9. chore: cleanup after branch update

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f8a09bd View commit details
    Browse the repository at this point in the history

  10. chore: remove console log

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    a54ffce View commit details
    Browse the repository at this point in the history

  11. chore: remove a little bit of duplication

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    9879753 View commit details
    Browse the repository at this point in the history

  12. chore: remove badrequesterror 

    ☝️ this only exists in the frontend, so we can remove it here.
    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    7fb6f37 View commit details
    Browse the repository at this point in the history

  13. chore: extract get-prop-from-string function. 

    Because it's kinda tricky and not immediately obvious. This makes it
clearer what it does and what expectations I have for it.
    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    ea15a7a View commit details
    Browse the repository at this point in the history

  14. chore: simplify owaspvalidationerror format

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    7ca15ca View commit details
    Browse the repository at this point in the history

  15. refactor: rely on inheritance to propagate required extra fields

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    9197dc3 View commit details
    Browse the repository at this point in the history

  16. chore: remove unused error string. 

    This was added by mistake. We never actually used it anywhere. The
error is just called `PasswordMismatch`
    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    48544de View commit details
    Browse the repository at this point in the history

  17. chore: typo

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    7753491 View commit details
    Browse the repository at this point in the history

  18. chore: add extra logging when we get an unexpected error type

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    e477e2b View commit details
    Browse the repository at this point in the history

  19. chore: add new error types

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    7ff3e95 View commit details
    Browse the repository at this point in the history

  20. chore: add other missing error type

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    539b800 View commit details
    Browse the repository at this point in the history

  21. chore: make bad data errors put message in top level if no errors

    @thomasheartman
    thomasheartman committed May 8, 2023
    Configuration menu
    Copy the full SHA
    b3c2e18 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. chore: use error.statusCode instead of explicit number.

    @thomasheartman
    thomasheartman committed May 9, 2023
    Configuration menu
    Copy the full SHA
    8d8dec8 View commit details
    Browse the repository at this point in the history

  2. Chore: fill out missing words in test name

    @thomasheartman
    thomasheartman committed May 9, 2023
    Configuration menu
    Copy the full SHA
    c1fdbfd View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. chore: remove redundant constructors and super calls

    @thomasheartman
    thomasheartman committed May 10, 2023
    Configuration menu
    Copy the full SHA
    59517e2 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Chore: use lodash.get instead of homegrown getPropFromString

    @thomasheartman
    thomasheartman committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e002678 View commit details
    Browse the repository at this point in the history

  2. chore: extract methods

    @thomasheartman
    thomasheartman committed May 11, 2023
    Configuration menu
    Copy the full SHA
    b1b7a29 View commit details
    Browse the repository at this point in the history

  3. refactor: use expect().toMatchObject when there are multiple props

    @thomasheartman
    thomasheartman committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c21a299 View commit details
    Browse the repository at this point in the history

  4. chore: remove redundant tests

    @thomasheartman
    thomasheartman committed May 11, 2023
    Configuration menu
    Copy the full SHA
    aa21d78 View commit details
    Browse the repository at this point in the history

  5. chore: rename api-error to unleash-error

    @thomasheartman
    thomasheartman committed May 11, 2023
    Configuration menu
    Copy the full SHA
    71cf907 View commit details
    Browse the repository at this point in the history