Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing options parameter back in #3770

Merged
merged 1 commit into from May 15, 2023
Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented May 15, 2023

This PR adds the missing serialization of the AuthenticationRequired response back in. It was mistakenly removed in #3633.

This PR also adds another test to verify that it the options property is present.

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 7:10am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 7:10am

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM.

@thomasheartman thomasheartman enabled auto-merge (squash) May 15, 2023 07:14
@thomasheartman thomasheartman merged commit 741135a into main May 15, 2023
15 of 18 checks passed
@thomasheartman thomasheartman deleted the fix/missing-options branch May 15, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants