chore: document endpoint tagged Unstable #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Nice work! Got some suggestions to clear up a bit. Export/import is a complicated domain, so it's hard to know how best to do it.
I also have a few questions:
- There's no schemas in this PR. Are you putting them in a separate PR?
- This PR does not include any error responses for these endpoints (400, 401, 403, etc). Is that also something you're putting in a different PR or an oversight?
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
|
@thomasheartman Thanks for the feedback. I will add schema descriptions to this PR. |
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
…ore/open_api_unstable
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
# Conflicts: # src/lib/openapi/util/openapi-tags.ts
thomasheartman
approved these changes
Jun 30, 2023
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds description and summary to all endpoints with
UnstabletagAbout the changes
Closes # 1-1001
Important files
Discussion points