Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency dialogue #4828

Merged
merged 10 commits into from
Sep 26, 2023
Merged

Add dependency dialogue #4828

merged 10 commits into from
Sep 26, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Sep 25, 2023

About the changes

Button for opening dependency modal:
Screenshot 2023-09-25 at 15 21 32

Dependency modal itself with no logic yet:
Screenshot 2023-09-25 at 15 21 20

Important files

Discussion points

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 1:57pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2023 1:57pm

@@ -105,7 +105,10 @@ export const FeatureEnvironmentSeen = ({
)
}
elseShow={
<TooltipContainer tooltip="No usage reported from connected applications">
<TooltipContainer
sx={sx}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI fix for code that was broken before

<StyledSelect
fullWidth
options={[
{ key: 'a', label: 'featureA' },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add real options in another PR

@kwasniew kwasniew merged commit 2b96782 into main Sep 26, 2023
15 checks passed
@kwasniew kwasniew deleted the add-dependency-dialogue branch September 26, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants