feat: read model for dependent features #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
requested review from
sjaanus,
FredrikOseberg,
Tymek,
andreas-unleash and
thomasheartman
FredrikOseberg
approved these changes
Sep 27, 2023
Comment on lines
+26
to
+42
| async getParentOptions(child: string): Promise<string[]> { | ||
| const result = await this.db('features as f') | ||
| .where('f.name', child) | ||
| .select('f.project'); | ||
| if (result.length === 0) { | ||
| return []; | ||
| } | ||
| const rows = await this.db('features as f') | ||
| .leftJoin('dependent_features as df', 'f.name', 'df.child') | ||
| .where('f.project', result[0].project) | ||
| .andWhere('f.name', '!=', child) | ||
| .andWhere('df.child', null) | ||
| .select('f.name'); | ||
|
|
||
| return rows.map((item) => item.name); | ||
| } | ||
| } |
There was a problem hiding this comment.
Would prefer features as feature to help with scanning.
There was a problem hiding this comment.
Will update in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Introducing read model separate from the write model using store. The read model can be used by the feature overview to get parents/children without exposing write DB operations.
Important files
Discussion points