Instance stats service composition root #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Jan 25, 2024
| @@ -20,7 +33,7 @@ afterAll(async () => { | |||
| }); | |||
|
|
|||
| test('should return instance statistics', async () => { | |||
| stores.featureToggleStore.create('default', { | |||
| await stores.featureToggleStore.create('default', { | |||
kwasniew
commented
Jan 25, 2024
| { | ||
| experimental: { | ||
| flags: { | ||
| strictSchemaValidation: true, |
There was a problem hiding this comment.
missing schema validation
kwasniew
commented
Jan 25, 2024
| @@ -97,6 +98,7 @@ export default async function init( | |||
| getLogger, | |||
| }); | |||
|
|
|||
| log.setLogLevel('error'); | |||
There was a problem hiding this comment.
stop logging db migration messages in all tests
There was a problem hiding this comment.
Awesome! This was something I was planning to do yesterday 🥇
daveleek
approved these changes
Jan 25, 2024
gastonfournier
approved these changes
Jan 25, 2024
| @@ -97,6 +98,7 @@ export default async function init( | |||
| getLogger, | |||
| }); | |||
|
|
|||
| log.setLogLevel('error'); | |||
There was a problem hiding this comment.
Awesome! This was something I was planning to do yesterday 🥇
Comment on lines
+306
to
+308
| const instanceStatsService = db | ||
| ? createInstanceStatsService(db, config) | ||
| : createFakeInstanceStatsService(config); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Ability to create a dependency graph of the instance stats service in one method call. This PR shows high coupling to 10+ stores we have in this part of the code.
Important files
Discussion points