chore: add a generic error for limit's exeeded #6452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
nunogois
reviewed
Mar 6, 2024
nunogois
reviewed
Mar 6, 2024
src/lib/error/exeeds-limit-error.ts
Outdated
| export class ExeedsLimitError extends GenericUnleashError { | ||
| constructor(resource: string, limit: number) { | ||
| super({ | ||
| name: 'ValidationError', // it can also be 'OperationDeniedError' or we can create a new one |
There was a problem hiding this comment.
Why not call it ExceedsLimitError?
There was a problem hiding this comment.
I did, let's see how it goes :D
nunogois
approved these changes
Mar 6, 2024
gastonfournier
commented
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
We don't have a meaningful error for limits established by the application. This could be a good starting point.
The error code is 400 cause I couldn't find anything better.
The name of the error was picked from UnleashApiErrorTypes:
unleash/src/lib/error/unleash-error.ts
Lines 4 to 34 in 2d8e9f8