feat: frontend api clean up not needed columns #6489
Conversation
sjaanus
commented
Mar 11, 2024
sjaanus
commented
- Clean up not used fields
- Fix a bug where segment was not attached
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -142,6 +140,9 @@ export default class ClientFeatureToggleReadModel | |||
| feature.strategies = feature.strategies || []; | |||
| feature.strategies.push(this.rowToStrategy(row)); | |||
| } | |||
| if (row.segment_id) { | |||
There was a problem hiding this comment.
This was missing from new query
| @@ -36,7 +36,6 @@ export default class ClientFeatureToggleReadModel | |||
| 'features.project as project', | |||
| 'features.stale as stale', | |||
| 'features.impression_data as impression_data', | |||
| 'features.created_at as created_at', | |||
| @@ -118,7 +117,6 @@ export default class ClientFeatureToggleReadModel | |||
| project: row.project, | |||
| stale: row.stale, | |||
| type: row.type, | |||
| dependencies: [], | |||
There was a problem hiding this comment.
This is same as in old frontend api.
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Overall Code Complexity client-feature-toggle-read-model.ts
- Complex Method client-feature-toggle-read-model.ts: ClientFeatureToggleReadModel.getAggregatedData
| if (row.segment_id) { | ||
| this.addSegmentIdsToStrategy(feature, row); | ||
| } |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
ClientFeatureToggleReadModel.getAggregatedData increases in cyclomatic complexity from 13 to 14, threshold = 9
Why does this problem occur?
This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring. Read more.
To ignore this warning click here.
| @@ -36,7 +36,6 @@ export default class ClientFeatureToggleReadModel | |||
| 'features.project as project', | |||
| 'features.stale as stale', | |||
| 'features.impression_data as impression_data', | |||
| 'features.created_at as created_at', | |||
There was a problem hiding this comment.
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 4.29 across 7 functions. The mean complexity threshold is 4
Why does this problem occur?
This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals. Read more.
To ignore this warning click here.
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Overall Code Complexity client-feature-toggle-read-model.ts
- Complex Method client-feature-toggle-read-model.ts: ClientFeatureToggleReadModel.getAggregatedData
